Revise operation in rangebreaks #4660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/plots/cartesian/set_convert.js
Outdated
|
|
||
| if(onOpenBound && op0 === '(' && v === b0) return BADNUM; | ||
| onOpenBound = op1 === ')' && v === b1; | ||
| if(onOpenBound && v === b0) return BADNUM; |
There was a problem hiding this comment.
Looks like onOpenBound can just be 🔪 at this point?
There was a problem hiding this comment.
Good eye. Done in c4dde70.
| }, | ||
| { | ||
| "pattern": "hour", | ||
| "bounds": [ 16, 8 ], | ||
| "operation": "()" | ||
| "bounds": [ 16.001, 8 ] |
alexcjohnson
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Fantastic! Just one small comment https://github.com/plotly/plotly.js/pull/4660/files?short_path=6ccd23f#r394320834 and this is ready to 💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #4614, and in regards with #4655 (comment) and #4655 (comment)
commits in this PR are steps to change default
operationto[)and make it internal.@plotly/plotly_js